Add the possibility for the RestTemplate library to enable collecting generic URI metrics #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metrics with URI template instead of the concrete URI.
Currently when doing a call to the resource path:
/shipments/{shipmentId}
with the shipmentId 123, the spring boot metric "http.client.requests" will contain the tag "uri" with the value "shipments/123".
The current change makes the resttemplate calls with appropriate uri variables when needed allowing therefor having the template "uri" tag values (e.g. : "shipment/{shipmentId}" in the previously mentioned example) for the spring boot metric "http.client.requests".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility for the RestTemplate library to enable collecting metrics with URI template instead of the concrete URI.
Currently when doing a call to the resource path:
/shipments/{shipmentId}
with the shipmentId 123, the spring boot metric "http.client.requests" will contain the tag "uri" with the value "shipments/123".
The current change makes the resttemplate calls with appropriate uri variables when needed allowing therefor having the template "uri" tag values (e.g. : "shipment/{shipmentId}" in the previously mentioned example) for the spring boot metric "http.client.requests".