New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java boolean field generation fixes #599

Open

fafee-io wants to merge 2 commits into swagger-api:master from fafee-io:bug/598-java-boolean-fixes

fafee-io commented Feb 13, 2020

Closes #598

This PR does the following:

Adds a piece of logic that determines if boolean or Boolean should be used, based on whether or not the field is nullable
Changes the getter's generation so that it is determined by the fields derived type and uses "is" for the primitive, "get" for the wrapper.
Added a test for the possibilities: nullable, nonNullable or not specified (defaults to false, as in nonNullable)

fafee-io added 2 commits

February 13, 2020 14:33


          java boolean field generation fixes

fbfb37d

logic to determine primitive vs wrapper type
logic to derive the getter from above type
tests


          adjusted existing boolean property test

5ff10ba

fafee-io requested a review from HugoMario

February 17, 2020 08:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet