#592 Ported automatic access token retrieval from openapi-generator #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generator The OpenAPITools/openapi-generator generates Java client SDK with okHttp which provides an automatic retrieval of an OAuth2 access token. This is done by registering an interceptor (RetryingOAuth class) extending the OAuth class to the okHTTP client instantiated in the ApiClient class. With that any outgoing HTTP call from the client SDK is intercepted and preceeding call to the Auth-Server is done first to retrieve an access token. That access token is then added to the original outgoing HTTP call providing an authorized access to the actual API.
|
@HugoMario - Hints for code review: I'm not sure if the OAuthOkHttpClient.mustache and RetryingOAuth.mustache should only be included in the generating process within JavaClientCodegen.java if OAuth is specified in the corresponding YAML. In OpenAPITools/openapi-generator, from which I ported the corresponding code, it is done that way. However, the OAuth.mustache template is also always included. For that I followed the same approach for the new templates. |
trohrberg
pushed a commit
to trohrberg/swagger-codegen-generators
that referenced
this pull request
Feb 15, 2020
…generator The OpenAPITools/openapi-generator generates Java client SDK with okHttp which provides an automatic retrieval of an OAuth2 access token. This is done by registering an interceptor (RetryingOAuth class) extending the OAuth class to the okHTTP client instantiated in the ApiClient class. With that any outgoing HTTP call from the client SDK is intercepted and preceeding call to the Auth-Server is done first to retrieve an access token. That access token is then added to the original outgoing HTTP call providing an authorized access to the actual API. Changes for pull request swagger-api#592: (swagger-api#593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #592
The OpenAPITools/openapi-generator generates Java client SDK with okHttp which provides an automatic retrieval of an OAuth2 access token. This is done by registering an interceptor (RetryingOAuth class) extending the OAuth class to the okHTTP client instantiated in the ApiClient class. With that any outgoing HTTP call from the client SDK is intercepted and preceeding call to the Auth-Server is done first to retrieve an access token. That access token is then added to the original outgoing HTTP call providing an authorized access to the actual API.