Implement import export library #2665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app:activemembers
|
Code Climate has analyzed commit 53db1d8 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Django tests seem to fail because the export action is moved, this is expected, because it now uses the resource class. Not sure why pylint fails. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
…port implementations
stefanvi
force-pushed
the
1081-implement-import-export-library
branch
from
a9d18f4 to
f00b01a
Compare
DeD1rk
force-pushed
the
master
branch
2 times, most recently
from
41d42a7 to
18edd09
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, the django-import-export library is partially implemented, issue #1081. The list below shows which classes still need to be implemented.
The last two are difficult because they have querysets that contain the actual data that needs to be exported. Registrations in case of Event and Payments in case of Batch. Also, the current event exporter has a lot of additional logic, which makes it difficult to define a resource class for it.