Fixed LayoutProps type typos

[mocanew]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
next-roots	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 11, 2023 11:56am

[svobik7]

Hi @mocanew,

could you please elaborate a bit on the motivation behind this PR?

IMO: I would keep the ‘pageLocale’ naming here. It was done on purpose to distinguish from native nextjs i18n naming https://nextjs.org/docs/pages/building-your-application/routing/internationalization. Also it would be unnecessary breaking change.

[mocanew]

I should've stated the problem from the get-go: the type LayoutProps is not accurate/in-sync with generated code. I see no problem with either naming, but I assumed the implementation to be correct rather than the type.

Here's one example that uses locale instead of pageLocale (I assume the other examples are the same): https://github.com/svobik7/next-roots/blob/master/examples/basic/src/features/common/components/Layout.tsx#L32. Also, RootLayoutProps should extend LayoutProps.

[svobik7]

Oh, you are right. For Layout it should be only locale. So your fix is right. Thank you 👍

[github-actions]

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀