Add docker build with all formatting tools #82
Conversation
svix-mman
force-pushed
the
mendy/add-docker-builds
branch
from
5914a3c to
108c343
Compare
|
@svix-onelson indeed, I want @svix-jplatte to have the final say here |
svix-mman
force-pushed
the
mendy/add-docker-builds
branch
from
b025af1 to
20234f7
Compare
Co-authored-by: Jonas Platte <[email protected]>
|
|
||
| - name: Export digest | ||
| # we create empty files with the sha256 digest of the docker image as the filename | ||
| # since we did not push with a tag, the only way to identify the image is with the digest |
There was a problem hiding this comment.
Down the line we should probably do releases for openapi-codegen and its Docker image, but for now this seems like a good start 👍
src/generator.rs
Outdated
| if !self.output_dir.exists() { | ||
| fs::create_dir_all(self.output_dir)?; | ||
| } |
There was a problem hiding this comment.
Do we actually have to check whether the dir exists first? I would expect that calling create_dir_all on an already-existing directory is a no-op.
Also can't this happen further up the call tree? So we run it once per invocation, rather than once per template invocation?
There was a problem hiding this comment.
Do we actually have to check whether the dir exists first? I would expect that calling
create_dir_allon an already-existing directory is a no-op.
Just tested it and you are right, not sure why the docs mention this If this function returns an error, some of the parent components might have been created already.
Also can't this happen further up the call tree? So we run it once per invocation, rather than once per template invocation?
Good call, let me move it up the call tree
Co-authored-by: Jonas Platte <[email protected]>
Using the docker image from svix/openapi-codegen#82 This results in the identical code. I replaced the `regen_openapi.sh` with a multi-threaded python script
This PR adds a arm64/amd64 docker image that include
openapi-codegenrustfmt +nightly(Rust)biome(JS/TS)ruff(Python)google-java-format(Java)ktfmt(Kotlin)rubyfmt(Ruby)goimports(Go)gofmt(Go)csharpier(C#)The
docker-release.ymlworkflow builds and releases a new image on every push to mainThe images are pushed to
ghcr.io/svix/openapi-codegenwith taglatestand<date>-<git rev-parse --short>(20250228-ffac537)I build the
arm64image usingubuntu-24.04-armrunnersThere is a little bit of a hack I have to do to get 2 separate builds for
arm64/amd64published under the same tagBut this is way faster then using QEMU!
Once the arm64 github runner is stable I want to use it in our svix-webhooks docker releases (instead of QEMU)