-
Notifications
You must be signed in to change notification settings - Fork 478
Take into account of parent transforms #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mrbean-bremen Re-run? |
What kind of |
<svg viewBox="0 0 100 100">
<text transform="translate(10 30)">
<tspan id="target">ABC</tspan>
</text>
</svg> Bounds of |
Thanks. What happens with this SVG ? <svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="100" height="100">
<text>
<tspan transform="translate(10 30)">ABC</tspan>
</text>
</svg> Many major browsers don't show anything for this SVG. ( |
<tspan> doesn't support transforms by itself, correct. But its bounds should use its parent transforms to result in the same bounds for the <text> and <tspan> elements since they do represent the same text at the same location. |
It doesn't seem to work properly with latest master, can it be fixed by merging this PR ? |
Yes, this is what I aim to fix. |
It doesn't seem to be fixed... |
In this case, it's the problem of the parser, and Bounds just takes information from the object tree. Out of scope. |
<svg viewBox="0 0 100 100">
<text transform="translate(10 30)">
<tspan id="target">ABC</tspan>
</text>
</svg> This PR fixes this, and this only. |
Hmm, actually this issue may exist across different element types, not just <tspan>. |
Superceded by #945 |
No description provided.