Use Character.isEmojiPresentation(int) instead of Character.isEmoji(i…

…nt) which excludes e.g. digit that are technically an emoji but do not have a representation (TweetWallFX#1961)
svenreimers · Oct 5, 2024 · 4857a97 · 4857a97
1 parent cbf5f4f
commit 4857a97
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 2 deletions.
diff --git a/emoji/src/main/java/org/tweetwallfx/emoji/Emojify.java b/emoji/src/main/java/org/tweetwallfx/emoji/Emojify.java
@@ -40,7 +40,7 @@ public static List<Object> tokenizeStringToTextAndEmoji(final String message) {
         for (int idx = 0; idx < codePoints.length; idx++) {
             var cp = codePoints[idx];
 
-            if (Character.isEmoji(cp)) {
+            if (Character.isEmojiPresentation(cp)) {
                 // we have an emoji
                 if (idx != idxStart) {
                     // prior to the emoji is a non-empty text

diff --git a/emoji/src/test/java/org/tweetwallfx/emoji/EmojifyTest.java b/emoji/src/test/java/org/tweetwallfx/emoji/EmojifyTest.java
@@ -1,7 +1,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2023 TweetWallFX
+ * Copyright (c) 2023-2024 TweetWallFX
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -54,6 +54,74 @@ static Stream<Arguments> parameters() {
                                 " Awesome emojis! ",
                                 new Twemoji("1f609")
                         }
+                ),
+                arguments(
+                        "Wired 2.0! Create your ultimate learning environment",
+                        new Object[]{
+                                "Wired 2.0! Create your ultimate learning environment"
+                        }
+                ),
+                arguments(
+                        "HTTP 1.0",
+                        new Object[]{
+                                "HTTP 1.0"
+                        }
+                ),
+                arguments(
+                        "0",
+                        new Object[]{"0"}
+                ),
+                arguments(
+                        "1",
+                        new Object[]{"1"}
+                ),
+                arguments(
+                        "2",
+                        new Object[]{"2"}
+                ),
+                arguments(
+                        "3",
+                        new Object[]{"3"}
+                ),
+                arguments(
+                        "4",
+                        new Object[]{"4"}
+                ),
+                arguments(
+                        "5",
+                        new Object[]{"5"}
+                ),
+                arguments(
+                        "6",
+                        new Object[]{"6"}
+                ),
+                arguments(
+                        "7",
+                        new Object[]{"7"}
+                ),
+                arguments(
+                        "8",
+                        new Object[]{"8"}
+                ),
+                arguments(
+                        "9",
+                        new Object[]{"9"}
+                ),
+                arguments(
+                        "#",
+                        new Object[]{"#"}
+                ),
+                arguments(
+                        "*",
+                        new Object[]{"*"}
+                ),
+                arguments(
+                        "©",
+                        new Object[]{"©"}
+                ),
+                arguments(
+                        "®",
+                        new Object[]{"®"}
                 )
         );
     }