Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH Actions fail-fast usage #198

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 12, 2023

@Rotzbua Rotzbua changed the title Fix GH Actions: Fix GH Actions Sep 12, 2023
Copy link
Owner

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How annoying! Great catch, thanks for sending the patch. Probably I will need to revisit the CI infra here again but for now the bandaids are very welcome and appreciated, thanks :)

Going to let CI run through before merging but this looks great.

@svenevs svenevs changed the title Fix GH Actions Fix GH Actions fail-fast usage Oct 19, 2023
@svenevs svenevs closed this Oct 19, 2023
@svenevs
Copy link
Owner

svenevs commented Oct 19, 2023

codecov triggers were broken, attempting relaunch now

@svenevs svenevs reopened this Oct 19, 2023
@svenevs svenevs merged commit f4d37fd into svenevs:master Oct 19, 2023
27 of 43 checks passed
@svenevs
Copy link
Owner

svenevs commented Oct 19, 2023

Beautiful 🙃

@Rotzbua Rotzbua deleted the fix_gh_actions branch October 19, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants