test(e2e): add simple Svelte 5 suite #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I'm still buried in work. It is passing now, I hope to get to it on the weekend. |
|
No worries, let me know if there's any way I can help lighten the load! For context, I'd like to land testing-library/svelte-testing-library#375 soon for "proper" Svelte 5 support (i.e. without using Svelte's legacy wrappers) in testing-library, but this would break Jest without svelte-jester support, so I'm holding off for the time being until we can land #284 and #283 here. This definitely isn't a fire while Svelte is still pushing v5 on its prerelease |
sebastianrothe
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a companion #283. It adds a simple Svelte 5 test suite to the repository's
e2edirectory. For now, Svelte 5 module tests are skipped, because they require #283 to passWhen run locally on my machine, this suite passes againstmaster. This is a bit unexpected to me, given that I can't get Svelte 5 to work properly with @testing-library/svelte-testing-library#375. Putting this PR up to aid investigation!Update: it looks like it a build issue! Running Svelte 5 E2E tests locally now properly fails after 6a51913