Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade @testing-library/svelte for svelte 4 support #131

Closed
wants to merge 2 commits into from
Closed

chore: upgrade @testing-library/svelte for svelte 4 support #131

wants to merge 2 commits into from

Conversation

benmccann
Copy link
Collaborator

No description provided.

@sebastianrothe
Copy link
Collaborator

I think it might be possible to ditch CJS with Svelte4 and make this code and samples easier. This should be a new major version, then.

@benmccann
Copy link
Collaborator Author

benmccann commented Jul 20, 2023 •
edited
Loading

@testing-library/svelte dropped CJS support with the latest version, so the example project only works as ESM. I've updated this PR to convert it to ESM. I don't know if that's the best approach though. It's probably helpful to have a CJS project for testing at least for now

@benmccann benmccann marked this pull request as draft July 20, 2023 20:26
@benmccann benmccann closed this Jul 23, 2023
@benmccann benmccann deleted the testing-lib branch July 23, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmccann @sebastianrothe