Feature/update packages #100

sebastianrothe · 2022-02-13T13:42:53Z

Upgrade all packages
Update e2e templates (svelte, sveltekit)

… be of type string. Received an instance of URL

…TYPE

benmccann · 2022-02-14T21:00:07Z

src/transformer.js

@@ -44,7 +55,7 @@ const processSync = (source, filename, jestOptions) => {
  const preprocessor = require.resolve('./preprocess.js')

  const preprocessResult = execSync(
-        `node --unhandled-rejections=strict --abort-on-uncaught-exception "${preprocessor}"`,
+        `node --experimental-vm-modules --unhandled-rejections=strict --abort-on-uncaught-exception "${preprocessor}"`,


is this supposed to be in this PR? it looks like what you were trying to add in #101 instead?

I got it a little bit mixed up :) I will move some of my commits to #101 instead.

Or is it okay, because both go hand in hand?

this one seems better on #101 to me

Okay, i am going to move it.

src/transformer.js

benmccann · 2022-02-14T21:02:18Z

these are all great updates!

benmccann · 2023-07-19T21:35:07Z

The PR queue got terribly backed up with dependabot alerts and the CI had broken due to bitrot. I fixed those issues not noticing this PR, so some of the updates have already gone in. A lot of the other changes in this PR look to duplicate #101, so probably we should review that one first and then see what's left that needs to be updated here

It looks the like SvelteKit e2e example is very outdated as it's pre-1.0. It might be easiest to just create a new SvelteKit project and add svelte-jester to it rather than trying to update it to the latest version of SvelteKit.

sebastianrothe · 2023-07-20T08:10:52Z

Wow, thanks for the effort. And sorry, that I never found the time a year ago :(

The e2e samples are really just generated. I had it document in the README. So they can b

In my opinion, the e2e folder should be excluded from dependabot (I already have a PR on my local machine),because this is just for tests and not the distributed code.

#100 still needs to be cleaned from the mixup with #101. Good news is: I actually have some time this week, because I am going freelance. So I will push some PRs. If you can find the time to review, that would be great.

Would love to bring Svelte4 support, afterwards.

correct README

The path to the preprocessor was being used in the command with surrounding quotes, which lead to it failing when there is a space in the path with errors like this: ``` Test suite failed to run Command failed: node --unhandled-rejections=strict --abort-on-uncaught-exception D:\University\Year 4\<long path with more spaces>\node_modules\svelte-jester\dist\preprocess.js Uncaught Error: Cannot find module 'D:\University\Year' ``` This should fix the problem and allow for spaces in the path.

- v12 is supported until April 2022

- remove v12 - add v17 for CI

fix: add missing jest-environment-jsdom testing-library/svelte@4 requires ESM

sebastianrothe · 2023-07-20T16:37:23Z

@benmccann I have cleaned the PR from commits of #101 and refreshed the samples for svelte and sveltekit.

benmccann · 2023-07-20T18:35:45Z

TODO.md

+- add eslint with plugins (svelte, import, promise)
+- use different config loader https://github.com/unjs/c12
+- use different build tool https://github.com/unjs/unbuild
+- 


empty bullet

Suggested change

-

Oops, I accidentally commited my TODO list :)

benmccann · 2023-07-20T18:35:55Z

TODO.md

+- use different config loader https://github.com/unjs/c12
+- use different build tool https://github.com/unjs/unbuild
+- 
+- add https://github.com/TrySound/rollup-plugin-terser


I prefer unminified developer tools as it makes debugging them so much easier. Plus, npm has compression anyway

Yeah, thats true.

benmccann · 2023-07-20T18:37:38Z

TODO.md

+- cleanup README
+- add eslint with plugins (svelte, import, promise)
+- use different config loader https://github.com/unjs/c12
+- use different build tool https://github.com/unjs/unbuild


I like that this project is using Rollup now. It's so common in the Svelte ecosystem it makes it really easy to pick up and start working on the project. I've never used unbuild on the otherhand. I think there's also some possibility we could ship unbundled ESM and don't even need a build tool at all

Im fine with rollup. The build tool is really just needed to convert ESM to CJS.

.npmrc

e2e/svelte/scripts/setupTypeScript.js

package.json

Co-authored-by: Ben McCann <[email protected]>

adyshev and others added 3 commits January 29, 2022 18:39

Fix for BUG 72 (OSX) - [ERR_INVALID_ARG_TYPE]: The "id" argument must…

5b03e30

… be of type string. Received an instance of URL

Merge pull request svelteness#93 from adyshev/fix-72-ERR_INVALID_ARG_…

52631ca

…TYPE

use experimental flag for svelte config import

c2278ca

sebastianrothe added the dependencies Pull requests that update a dependency file label Feb 14, 2022

sebastianrothe requested review from mihar-22 and benmccann February 14, 2022 19:40

sebastianrothe mentioned this pull request Feb 14, 2022

Feature/esm as default transformer #101

Closed

benmccann reviewed Feb 14, 2022

View reviewed changes

src/transformer.js Outdated Show resolved Hide resolved

mihar-22 approved these changes Feb 16, 2022

View reviewed changes

sebastianrothe and others added 17 commits July 20, 2023 13:18

upgrade packages

892dfbb

fix: use recommended language declaration

f559266

chore: update templates for e2e tests

37d56d8

feat: move some parts of setup into shell script

508050d

correct README

upgrade packages

1b2c746

upgrade packages in e2e

8ddb0e5

feat: bump min node version to 14

6069916

chore(release): 2.2.0

c1926f7

feat: bump min node version to 16

997f1f9

chore: update package-lock.json to v2

fe723ac

chore(release): 2.3.0

ed5dc17

chore: use https protocol for npm registry

5b1a407

fix: drop min node version to 14 for node-sass

3d7af1a

chore(release): 2.3.1

0f99a22

fix: set minimum node version to 12

5ce83ec

- v12 is supported until April 2022

fix: sveltekit requires node >= 14

fc618a4

- remove v12 - add v17 for CI

benmccann and others added 3 commits July 20, 2023 13:50

spacing

90cce70

chore: update links to repo

3a4ada2

fix: lock svelte < 4

e02f3d9

sebastianrothe force-pushed the feature/update-packages branch from 7baf450 to e02f3d9 Compare July 20, 2023 11:50

sebastianrothe added 9 commits July 20, 2023 13:52

feat: disallow unmaintained node version

d4385e9

fix: readd missing function

16b0245

fix: readd missing dash

e046593

fix: re-add missing import

b70f078

fix: call jest directly

8b06d9b

chore: update README

2e29dd2

fix: lock testing-library/svelte to 3.x

45399c3

fix: add missing jest-environment-jsdom testing-library/svelte@4 requires ESM

feat: update svelte samples for testing

1bf9e80

feat: update sveltekit sample for testing

b8e7a9c

benmccann reviewed Jul 20, 2023

View reviewed changes

.npmrc Outdated Show resolved Hide resolved

benmccann reviewed Jul 20, 2023

View reviewed changes

e2e/svelte/scripts/setupTypeScript.js Show resolved Hide resolved

benmccann reviewed Jul 20, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

sebastianrothe and others added 7 commits July 20, 2023 23:40

fix: replace node-sass with sass

7a13a3d

Co-authored-by: Ben McCann <[email protected]>

chore: upgrade packages

fe99119

feat: move some items to considerations

a8b908e

merge master

cc93b09

remove unnecessary file

8e21af3

fix package.json files

84ffe40

fix test

a70c6f7

benmccann approved these changes Jul 23, 2023

View reviewed changes

benmccann merged commit 1305396 into svelteness:master Jul 23, 2023
6 checks passed

sebastianrothe deleted the feature/update-packages branch July 23, 2023 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/update packages #100

Feature/update packages #100

sebastianrothe commented Feb 13, 2022 •

edited

Loading

benmccann Feb 14, 2022

sebastianrothe Feb 14, 2022

sebastianrothe Feb 14, 2022

benmccann Feb 15, 2022

sebastianrothe Feb 16, 2022

benmccann commented Feb 14, 2022

benmccann commented Jul 19, 2023

sebastianrothe commented Jul 20, 2023 •

edited

Loading

sebastianrothe commented Jul 20, 2023

benmccann Jul 20, 2023

sebastianrothe Jul 20, 2023

benmccann Jul 20, 2023

sebastianrothe Jul 20, 2023

benmccann Jul 20, 2023

sebastianrothe Jul 20, 2023

Feature/update packages #100

Feature/update packages #100

Conversation

sebastianrothe commented Feb 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benmccann commented Feb 14, 2022

benmccann commented Jul 19, 2023

sebastianrothe commented Jul 20, 2023 • edited Loading

sebastianrothe commented Jul 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastianrothe commented Feb 13, 2022 •

edited

Loading

sebastianrothe commented Jul 20, 2023 •

edited

Loading