feat: scope css to js module to allow treeshaking it (requires vite 6.2) #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
reviewed
Mar 5, 2025
bluwy
approved these changes
Mar 5, 2025
dominikg
force-pushed
the
feat/css-shake
branch
from
12b257d to
6fc698a
Compare
|
the regex approach is a bit less clunky i think. least clunk inside vps would be an option that allows users to define the tests themselves on filename+content, similar to dynamicCompileOptions. |
|
reninder to self: switch to css.hasGlobal sveltejs/svelte#15450 (comment) |
dominikg
force-pushed
the
feat/css-shake
branch
from
760df77 to
f46c622
Compare
bluwy
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see vitejs/vite#19418
This allows vite to treeshake unused svelte component css if the component was referenced in a barrel file.