Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add parenthesis back to regex literal example #9027

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

KaiErikNiermann
Copy link
Contributor

Fixes #9022

While not majorly important it could be mildly confusing for people just starting out. As pointed out by this issue and obviously the text above when using literal notation you need parenthesis or svelte will fail to parse the expression.

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2023

⚠️ No Changeset found

Latest commit: d450fea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gtm-nayan gtm-nayan changed the title fix: added parenthesis back to literal notation example docs: add parenthesis back to regex literal example Jul 24, 2023
@gtm-nayan gtm-nayan merged commit 5cd4f77 into sveltejs:master Jul 24, 2023
@gtm-nayan
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation text and sample are inconsistent: parentheses around RegExp literals
2 participants