-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default values in object destructuring #14554
fix: default values in object destructuring #14554
Conversation
🦋 Changeset detectedLatest commit: bfe3b71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14554-svelte.vercel.app/ this is an automated message |
|
To fix the failing lint test, run Prettier on your changed files. |
1961940
to
1123629
Compare
thank you! |
This PR addresses an issue where destructuring objects and arrays within an each block causes the compiler to break if the default value of a property contains a string with special characters like
}
or]
. The current validation logic does not correctly handle these cases and incorrectly interprets such characters when they are inside strings.Additionally, the solution includes support for template string syntax, ensuring these are also handled appropriately.
Resolves #12131
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint