Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sveltesociety.dev links #10035

Merged
merged 10 commits into from
Jan 4, 2024
Merged

docs: update sveltesociety.dev links #10035

merged 10 commits into from
Jan 4, 2024

Conversation

lachlancollins
Copy link

@lachlancollins lachlancollins commented Dec 30, 2023

Changes

This PR updates the sveltesociety.dev links to use URL query params to filter tags, rather than the previous URL fragment.

For example, https://sveltesociety.dev/packages#svelte-kit-adapters becomes https://sveltesociety.dev/packages?tag=sveltekit-adapters

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Copy link

changeset-bot bot commented Dec 30, 2023

⚠️ No Changeset found

Latest commit: 0baff48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

Sigh. I really wanted to give svelte-society/sveltesociety.dev#541 another look, but didn't get a chance yet due to the holidays. I think the new UI is pretty messy because of the huge list of tags on the top of the page and the change also conflicts with other plans I had for that page. Honestly I think we should consider reverting svelte-society/sveltesociety.dev#541 at least temporarily as I feel it needed more discussion. @MacFJA did you have a chance to take a look at that change?

@lachlancollins
Copy link
Author

Oh I'm so sorry @benmccann! I was eager to get this merged because I have a limited timeframe where I can smash out a bunch of tasks before life becomes a whole lot busier (indefinitely). I wasn't aware you had your own plans for this page either! I took @kevmodrome's positive feedback as approval.

This is what I see as the pros and cons of this change:

Pros:

  • Better functionality - When you apply a tag, it narrows your other tag options. This helps users apply all the conditions they want from their package.

  • Better UX - Applying tags now is just a single click, rather than a click, scroll/type, click. Also, having 2 separate select fields could be confusing - if an entry could fit under multiple categories, the user won't know which one we assigned to it.

  • Better discoverability - With category separation, the first alphabetical category always appears first, so you always see the same entries at the top, even with different sorting.

Cons:

  • Messier UI - There are a lot of tags on the packages page, so this isn't a perfect solution either. I have adjusted the CSS to reduce the amount of whitespace showing up on mobile layout.

I'd be interested in hearing if you had any suggestions for handling the UI problem. One idea I've had would be making them expandable/collapsible from a single row to all rows? Maybe we could continue discussion on Discord rather than this repo?

@benmccann
Copy link
Member

Thanks for all the updates! This is looking pretty good to me now. I left you a message on Discord earlier today. I think my one remaining question before merging this is about the URL. We can discuss on Discord, but thought I should share an update here in case anyone else tries to look at this PR

@benmccann benmccann changed the title docs: Update sveltesociety.dev links docs: update sveltesociety.dev links Jan 4, 2024
documentation/blog/2023-12-14-sveltekit-2.md Outdated Show resolved Hide resolved
documentation/docs/01-getting-started/01-introduction.md Outdated Show resolved Hide resolved
documentation/docs/05-misc/01-faq.md Outdated Show resolved Hide resolved
documentation/docs/05-misc/01-faq.md Outdated Show resolved Hide resolved
@benmccann benmccann merged commit bde282a into sveltejs:svelte-4 Jan 4, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants