-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update sveltesociety.dev
links
#10035
docs: update sveltesociety.dev
links
#10035
Conversation
|
Sigh. I really wanted to give svelte-society/sveltesociety.dev#541 another look, but didn't get a chance yet due to the holidays. I think the new UI is pretty messy because of the huge list of tags on the top of the page and the change also conflicts with other plans I had for that page. Honestly I think we should consider reverting svelte-society/sveltesociety.dev#541 at least temporarily as I feel it needed more discussion. @MacFJA did you have a chance to take a look at that change? |
Oh I'm so sorry @benmccann! I was eager to get this merged because I have a limited timeframe where I can smash out a bunch of tasks before life becomes a whole lot busier (indefinitely). I wasn't aware you had your own plans for this page either! I took @kevmodrome's positive feedback as approval. This is what I see as the pros and cons of this change: Pros:
Cons:
I'd be interested in hearing if you had any suggestions for handling the UI problem. One idea I've had would be making them expandable/collapsible from a single row to all rows? Maybe we could continue discussion on Discord rather than this repo? |
Thanks for all the updates! This is looking pretty good to me now. I left you a message on Discord earlier today. I think my one remaining question before merging this is about the URL. We can discuss on Discord, but thought I should share an update here in case anyone else tries to look at this PR |
sveltesociety.dev
linkssveltesociety.dev
links
Changes
This PR updates the sveltesociety.dev links to use URL query params to filter tags, rather than the previous URL fragment.
For example, https://sveltesociety.dev/packages#svelte-kit-adapters becomes https://sveltesociety.dev/packages?tag=sveltekit-adapters
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.