Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: bring REPL over #5

Merged
merged 15 commits into from
Jun 11, 2024
Merged

WIP: bring REPL over #5

merged 15 commits into from
Jun 11, 2024

Conversation

Rich-Harris
Copy link
Member

lots of stuff broken currently

we don't have the ability to mark PRs as draft while this repo is private, so 'WIP' will have to do

@dummdidumm
Copy link
Member

dummdidumm commented Jun 11, 2024

Where was the initial commit of the REPL package and the svelte.dev site from (what repo, what branch on that repo)? A bit surprised that we need to "bring the REPL over" when it's already in here.

@Rich-Harris
Copy link
Member Author

The REPL on the preview site has many unreleased changes

@dummdidumm
Copy link
Member

So you brought over the repl from the sites repo and are now replacing/merging it with the content from the preview site?

@Rich-Harris
Copy link
Member Author

yes

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 10:33pm

@dummdidumm
Copy link
Member

Regarding runes: it's too late now I guess but my idea was to have it working in legacy mode first to test the robustness of our backwards compat. Then run the migration script to see how good it already works.

@Rich-Harris
Copy link
Member Author

The preview REPL has been stress testing compatibility for the last several months — I'd say we pass. As for automated migration, I don't think the REPL is a great candidate as so much of it is gnarly store code that will need to be manually overhauled

@Rich-Harris
Copy link
Member Author

I can't for the life of me get the <CodeMirror> component to actually show the code. Editing works — it updates the Result tab — but it won't initialise correctly, and the JS and CSS output tabs are blank.

Going to log off for a bit and see if being outside somehow fixes it

@Rich-Harris
Copy link
Member Author

Downgrading neocodemirror fixed it — something to do with the new 'document mode'

Lots to do still but I think this is good enough to merge

@Rich-Harris Rich-Harris merged commit 2977cb7 into main Jun 11, 2024
2 of 3 checks passed
@Rich-Harris Rich-Harris deleted the repl branch June 11, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants