-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: bring REPL over #5
Conversation
Where was the initial commit of the REPL package and the svelte.dev site from (what repo, what branch on that repo)? A bit surprised that we need to "bring the REPL over" when it's already in here. |
The REPL on the preview site has many unreleased changes |
So you brought over the repl from the sites repo and are now replacing/merging it with the content from the preview site? |
yes |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Regarding runes: it's too late now I guess but my idea was to have it working in legacy mode first to test the robustness of our backwards compat. Then run the migration script to see how good it already works. |
The preview REPL has been stress testing compatibility for the last several months — I'd say we pass. As for automated migration, I don't think the REPL is a great candidate as so much of it is gnarly store code that will need to be manually overhauled |
I can't for the life of me get the Going to log off for a bit and see if being outside somehow fixes it |
Downgrading neocodemirror fixed it — something to do with the new 'document mode' Lots to do still but I think this is good enough to merge |
lots of stuff broken currently
we don't have the ability to mark PRs as draft while this repo is private, so 'WIP' will have to do