fix: set svelteFeatures.runes to true by default for Svelte 5
#538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9dea20b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
commented
Jun 17, 2024
| @@ -383,15 +385,13 @@ For example in `.eslintrc.*`: | |||
| "parser": "svelte-eslint-parser", | |||
| "parserOptions": { | |||
| "parser": "...", | |||
| "svelteFeatures": { "runes": true }, | |||
There was a problem hiding this comment.
I think 95% of users doesn't need to specify this option, so I removed from README.
baseballyama
force-pushed
the
fix/enable-rune-as-default
branch
2 times, most recently
from
e043530
to
153eb5b
Compare
baseballyama
force-pushed
the
fix/enable-rune-as-default
branch
from
153eb5b
to
06e2755
Compare
baseballyama
commented
Jun 17, 2024
| @@ -28,7 +28,7 @@ export function isEnableRunes( | |||
| } else if (svelteConfig?.compilerOptions?.runes != null) { | |||
| return Boolean(svelteConfig.compilerOptions.runes); | |||
| } | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
This is fundamental changes of this PR. If Svelte 5, the parser will recognize runes as default.
baseballyama
changed the title
svelteFeatures.runes to true by default for Svelte 5”svelteFeatures.runes to true by default for Svelte 5
baseballyama
changed the title
svelteFeatures.runes to true by default for Svelte 5svelteFeatures.runes to true by default for Svelte 5
|
Why test is failed~~~ |
|
@ota-meshi Does this PR reflect a shared understanding between us? |
Pull Request Test Coverage Report for Build 9549079734Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #536 (comment)