fix: Overrides SvelteKit version to v1 for the melt-ui
test
#13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a temporary override, pinning SvelteKit to v1 until Melt upgrades to SK v2. If temporarily pinning the version goes against the concept of ecosystem-ci, please feel free to close!
It looks like Melt keeps failing because it hasn't been upgraded to SK v2 yet. The current error shown in CI is due to this change: https://discord.com/channels/457912077277855764/1185088342929449080/1185230781359063040 which I've now reverted.
However, another error has cropped back up (the same error that presented in the linked discord thread above). While testing ecosystem-ci locally, I'm noticing that we're now failing due to
import { vitePreprocess } from '@sveltejs/kit/vite';
no longer being a valid export as it was removed in SK v2.The interesting bit is that Skeleton is still passing despite not being on SK v2 either. This leads me to believe that the dependencies for Skeleton aren't being replaced like they are for Melt. My best guess as to why that is is that Skeleton is in a monorepo and Melt isn't.
To test that this isn't just an isolated incident, I also added
bits-ui
andsvelte-ux
locally to see how they would hold up comparatively.bits-ui
errored, just like Melt, andsvelte-ux
didn't, just like Skeleton. Both, Skeleton andsvelte-ux
use monorepos, whilebits-ui
and Melt do not.Edit: Raised an issue for the monorepo deps discrepancy as this behavior doesn't seem to be intended.