Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Cache client files in dev mode too #1277

Closed
wants to merge 1 commit into from

Conversation

benmccann
Copy link
Member

It's unnecessary to disable the cache in development mode because all files under client/ contain hashes and so will not be cached if their contents change

Removing this has two benefits:

  • Faster reloads in development
  • Makes dev more like prod

@antony
Copy link
Member

antony commented Jun 16, 2020

I can see the benefit and reasoning for this, but anything to do with caching and local just sounds like it will drive me nuts. Even if it has almost no impact.

What I would like to see is maybe this merged with the ideas in #1173 to provide more control over caching in Sapper. That way people could disabled/enable local caching if they wanted to, but also have more control over caching generally.

@benmccann
Copy link
Member Author

If it causes issues with caching locally then it will in prod as well and I think it'd be better to discover that locally. That being said, this isn't very important to me, so feel free to close if you're still nervous about it

@Conduitry
Copy link
Member

I've definitely had a few occasions when debugging locally something where I manually edited files in /client/. That sort of thing would be harder with this. I agree with Antony, and don't think doing caching during local dev is a good idea.

@Conduitry Conduitry closed this Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants