fix: enable fallback watcher when dynamicRegistration is false #2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2008
In Linux, neovim's client capability is
didChangeWatchedFiles: { dynamicRegistration: false }. When this first happened, I think it was the client's responsibility to add the watcher in this case; however, it turned out to be a bit problematic, and it is the top 3 most commented closed issue 😅 . The neovim+Linux users are probably a lot more than the users using an lsp client that has a watcher config in the client. It also isn't as capable as our fallback watcher: it likely doesn't support as many file extensions, and we can't add a watcher outside the project root.