Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @joeinnes/svelte-image #176

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Add @joeinnes/svelte-image #176

merged 3 commits into from
Dec 16, 2023

Conversation

joeinnes
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 15, 2021 •
edited
Loading

✅ Deploy Preview for sveltesociety-preview ready!

Name Link
🔨 Latest commit 0642b9f
🔍 Latest deploy log https://app.netlify.com/sites/sveltesociety-preview/deploys/657d42c452f5580008beb290
😎 Deploy Preview https://deploy-preview-176--sveltesociety-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MacFJA
Copy link
Collaborator

MacFJA commented Jan 16, 2022

@joeinnes, Can you rebase your branch with staging and run npm run format ?

The formatting of src/routes/components/components.json is not correct (issue with end/start of the JSON object (https://github.com/svelte-society/sveltesociety.dev/pull/176/files#diff-d9f92e8e9adb76c17f488aefddaa940b6dfba83b2b212945311a1fc2fb637da7R2350))

@benmccann benmccann changed the title Update components.json Add @joeinnes/svelte-image Jan 26, 2022
benmccann
benmccann reviewed Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a reminder that this PR would need to be rebased

src/routes/components/components.json Outdated Show resolved Hide resolved
@MacFJA MacFJA added the need rebase The PR need to be rebased label Oct 10, 2022
@MacFJA MacFJA added the stale Issue or PR haven't be update for a while label Dec 4, 2022
@benmccann benmccann changed the base branch from staging to main July 9, 2023 03:09
@lachlancollins lachlancollins removed stale Issue or PR haven't be update for a while need rebase The PR need to be rebased labels Dec 16, 2023
@lachlancollins lachlancollins merged commit f658f41 into svelte-society:main Dec 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joeinnes @MacFJA @benmccann @lachlancollins