Skip to content

Commit

Permalink
Fix 2253
Browse files Browse the repository at this point in the history
  • Loading branch information
svartkanin committed Nov 24, 2023
1 parent f644632 commit b3ba2ae
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 1 addition & 3 deletions archinstall/lib/hardware.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class GfxPackage(Enum):
LibvaMesaDriver = 'libva-mesa-driver'
Mesa = "mesa"
Nvidia = 'nvidia'
NvidiaDKMS = 'nvidia-dkms'
NvidiaOpen = 'nvidia-open'
VulkanIntel = 'vulkan-intel'
VulkanRadeon = 'vulkan-radeon'
Expand Down Expand Up @@ -110,8 +109,7 @@ def packages(self) -> List[GfxPackage]:
]
case GfxDriver.NvidiaProprietary:
return [
GfxPackage.Nvidia,
GfxPackage.NvidiaDKMS
GfxPackage.Nvidia
]
case GfxDriver.VMOpenSource:
return [
Expand Down
2 changes: 1 addition & 1 deletion archinstall/lib/models/network_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def install_network_config(
case NicType.NM:
installation.add_additional_packages(["networkmanager"])
if profile_config and profile_config.profile:
if profile_config.profile.is_desktop_type_profile():
if profile_config.profile.is_desktop_profile():
installation.add_additional_packages(["network-manager-applet"])
installation.enable_service('NetworkManager.service')
case NicType.MANUAL:
Expand Down
4 changes: 3 additions & 1 deletion archinstall/lib/profile/profiles_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ def install_gfx_driver(self, install_session: 'Installer', driver: Optional[GfxD
if driver is not None:
driver_pkgs = driver.packages()
pkg_names = [p.value for p in driver_pkgs]

for driver_pkg in {GfxPackage.Nvidia, GfxPackage.NvidiaOpen} & set(driver_pkgs):
for kernel in {"linux-lts", "linux-zen"} & set(install_session.kernels):
# Fixes https://github.com/archlinux/archinstall/issues/585
Expand All @@ -221,6 +222,7 @@ def install_gfx_driver(self, install_session: 'Installer', driver: Optional[GfxD
install_session.add_additional_packages(['dkms', 'xorg-server', 'xorg-xinit', f'{driver_pkg.value}-dkms'])
# Return after first driver match, since it is impossible to use both simultaneously.
return

if 'amdgpu' in driver_pkgs:
# The order of these two are important if amdgpu is installed #808
if 'amdgpu' in install_session.modules:
Expand All @@ -245,7 +247,7 @@ def install_profile_config(self, install_session: 'Installer', profile_config: P

profile.install(install_session)

if profile_config.gfx_driver and (profile.is_xorg_type_profile() or profile.is_desktop_type_profile()):
if profile_config.gfx_driver and (profile.is_xorg_type_profile() or profile.is_desktop_profile()):
self.install_gfx_driver(install_session, profile_config.gfx_driver)

if profile_config.greeter:
Expand Down

0 comments on commit b3ba2ae

Please sign in to comment.