Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty FullyCharged and DesignCapacity #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow empty FullyCharged and DesignCapacity #93

wants to merge 1 commit into from

Conversation

horasal
Copy link

@horasal horasal commented Oct 31, 2021 •
edited
Loading

On MacMini M1(or maybe all devices with macOS 12, I haven't tested on other macs), FullyCharged and DesignCapacity are missing.
However, current both of them are required or PowerSource will throw an error. SourceCode e.g. the following error

[WARN] - (starship::modules::battery): Unable to access battery information:                                                             
FullyCharged

This pr makes PowerSource accepts empty FullyCharged and DesignCapacity.
If they are missing, users will get a default value. (i.e. true for FullyCharged and Default::default() for DesignCapacity).

Allow empty FullyCharged and DesignCapacity,
6aadf8f 
because these keys are empty on MacMini and MacPro.
`InstantData::try_from` should not throw error on empty values.
@matchai matchai mentioned this pull request Nov 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@horasal