Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix to ~0.23 #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

davidkna
Copy link

@davidkna davidkna commented Oct 13, 2021

nix has recently published a security advisory (RUSTSEC-2021-0119) and the nix version used in rust-battery is vulnerable. This PR updates nix (and MSRV) to the latest version and makes the necessary changes to have it successfully build for FreeBSD with cross.
Closes #89

@davidkna davidkna changed the title Update nix to ~0.22 Update nix to ~0.23 Oct 13, 2021
@ClementTsang
Copy link

this would also fix #91

@wez
Copy link

wez commented May 5, 2022

What will it take to land and publish this? (Should probably go with nix 0.24 at this point).
This problematic nix dep is flagging in cargo audit
wez/wezterm#1952

@ClementTsang
Copy link

I think the author doesn't seem to really be active on this project anymore. Might be worth just forking out your own version at this point.

wez added a commit to wez/wezterm that referenced this pull request May 5, 2022
The former is unmaintained and is flagging in cargo audit for its
indirect deps.

The starship folks have forked it; let's use that.

refs: svartalf/rust-battery#92
refs: #1952
@wez
Copy link

wez commented May 5, 2022

looks like starship-battery is a pre-existing fork so I'm going with that

@ClementTsang
Copy link

Oh, nice! I was looking for something similar; I'll update the linked issue to point people in a similar situation there in that case.

ClementTsang added a commit to ClementTsang/bottom that referenced this pull request May 6, 2022
Migrates the `battery` dependency to the more actively maintained
`starship-battery` fork, found at https://github.com/starship/rust-battery.
See svartalf/rust-battery#92 for more information.
ClementTsang added a commit to ClementTsang/bottom that referenced this pull request May 6, 2022
Migrates the `battery` dependency to the more actively maintained
`starship-battery` fork, found at https://github.com/starship/rust-battery.
See svartalf/rust-battery#92 for more information.
kpcyrd added a commit to kpcyrd/libredefender that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants