Feat: Place download button on label and make it smaller #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vibalre
commented
Nov 9, 2022
vibalre
commented
- Download button should only be a button with the download icon.
- The download button should be located on the top right of the cell container in line with the cell name.
Merge branch 'master' into feat/make-download-button-smaller # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
I really am not sure about this PR, for me it's really hard to see that there is a download button at all. Actually, it took me a few seconds to find it and that was knowing that it existed. If the user doesn't even know that the feature exists it might be even harder to find it.
I think our UI looks quite simple and clean and the current status looks nice. I'll keep this PR open for now until we hear other opinions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.