You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks to be a recently introduced bug in the DAGMC_macros.cmake file, where looking to compare the version number of double down. The issue is however in the ddConfigVersion.cmake produced from the DD build, the version number is set as a string "1.1.0" for example, but the DAGMC_macros.cmake file compares against against I dont really know what - the number is input as 1.1.0 - but its not a string nor an int.
I think either double down should be setting DD_MAJOR_VERSION 1 & DD_MINOR_VERSION 1, and those get checked in the macros file, or something similar. I'm surprised CI passes right now as is. Happy to fix, but need to know how DD should be fixed before upstream changes are made.
The text was updated successfully, but these errors were encountered:
Looks to be a recently introduced bug in the DAGMC_macros.cmake file, where looking to compare the version number of double down. The issue is however in the
ddConfigVersion.cmake
produced from the DD build, the version number is set as a string "1.1.0" for example, but theDAGMC_macros.cmake
file compares against against I dont really know what - the number is input as 1.1.0 - but its not a string nor an int.I think either double down should be setting DD_MAJOR_VERSION 1 & DD_MINOR_VERSION 1, and those get checked in the macros file, or something similar. I'm surprised CI passes right now as is. Happy to fix, but need to know how DD should be fixed before upstream changes are made.
The text was updated successfully, but these errors were encountered: