Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failiure to build DAGMC with Double Down #947

Closed
makeclean opened this issue Feb 28, 2024 · 1 comment · Fixed by #944
Closed

Failiure to build DAGMC with Double Down #947

makeclean opened this issue Feb 28, 2024 · 1 comment · Fixed by #944

Comments

@makeclean
Copy link
Contributor

Looks to be a recently introduced bug in the DAGMC_macros.cmake file, where looking to compare the version number of double down. The issue is however in the ddConfigVersion.cmake produced from the DD build, the version number is set as a string "1.1.0" for example, but the DAGMC_macros.cmake file compares against against I dont really know what - the number is input as 1.1.0 - but its not a string nor an int.

I think either double down should be setting DD_MAJOR_VERSION 1 & DD_MINOR_VERSION 1, and those get checked in the macros file, or something similar. I'm surprised CI passes right now as is. Happy to fix, but need to know how DD should be fixed before upstream changes are made.

@makeclean
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant