Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong image displayed for Interrupt Vector #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

omkar98
Copy link

@omkar98 omkar98 commented Apr 14, 2019

Commit 2: Uploaded the image representing the Interrupt Vector with the naming conventions as given for other images.
Commit 1: Replaced the image.

Referred to the following page number in the reference book: Page: 163

The details of the book I have used for reference:
THE DESIGN OF THE UNix® OPERATING SYSTEM
by Maurice J. Bach
ISBN-978-81-203-Q516-8
Indian edition published by PHI Learning Private Limited.
Published by Asoke K. Ghosh, PHI Learning Private Limited, M-97, Connaught
Circus, New Delhi-110001 and Printed by Baba Barkha Nath Printers, Bahadurgarh,
Haryana-124507.

omkar98 added 3 commits April 14, 2019 18:02
Interrupt vector was represented with an image of the Context of a Process. Replaced it with the actual screenshot.
The name of the image is given with the convention used for naming other images.
corrected spelling
@suvratapte
Copy link
Owner

suvratapte commented Apr 14, 2019

Thank you so much Omkar for your pull request. :)
There are a few things however:

Commit 1:
Can you rename it as: "Fix: Spelling of inode".

Commit 2 and 3:
You should squash commit 2 and 3 into one commit and name it as: "Fix: Interrupt vector image".

Let me know what do you think :)

@omkar98
Copy link
Author

omkar98 commented Apr 14, 2019

Sure Suvrat! Will do the necessary!

@@ -71,4 +71,4 @@ The kernel sometimes wants to prevent occurrence of interrupts when it is doing

### Memory Management

The kernel permanently resides in the main memory. When compiling a program, the compiler generates a set of addresses in the program that represent addresses of variables and data structures of the addresses of instructions such as functions. The compiler generates the addresses for a *virtual machine* as if no other program will execute simultaneously on the physical machine. When the program is run on the machine, the kernel allocates space in main memory for it, but the virtual addresses generated by the compiler need not be identical to the physical addresses that they occupy in the machine. The kernel coordinates with the machine hardware to set up a virtual to physical address translation that maps the compiler-generated addresses to the physical machine addresses.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any change here. Maybe only the line ending has changed. Will you please remove this change and resubmit? Thanks @omkar98 for your help! :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Yes. There's no change here. I did that by mistake..

@@ -2,7 +2,7 @@

## Why UNIX became so popular

* The system is written in a high-level language, making it easy to read, understand, change, and move to tother machines.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for spotting this! :)

@suvratapte
Copy link
Owner

Hi @omkar98, thanks for the new commit :)
Will you please update the last commits last well? If you want, we can get on a Hangouts call and make the required changes. Let me know.

@omkar98 omkar98 closed this May 16, 2019
@omkar98
Copy link
Author

omkar98 commented May 16, 2019

Oh! I am finding few issues with my git! I am new to GitHub, and used GitLab earlier. Anyways, will squash the previous commits as you mentioned earlier and will do the necessary changes.

@omkar98 omkar98 reopened this May 16, 2019
omkar98 added 2 commits May 16, 2019 15:39
1. contexts with contents
2. As mentioned in the book (pg. 41): Hence, the buffers that are closer to the head of the free list have not been used as recently as those that are further from the head of the free list.
has to hash.
full stop at the end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants