-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/an error when tried to run the rake task no method error undefined method file contents for nil nil class cu 86b1zgdgq #2
base: master
Are you sure you want to change the base?
Feature/an error when tried to run the rake task no method error undefined method file contents for nil nil class cu 86b1zgdgq #2
Conversation
c2ddca3
to
2097d9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of nice work in here, but I think it needs a bit of cleanup
2556eff
to
9d99e47
Compare
test/dummy/db/migrate/20240906180217_create_active_storage_tables.active_storage.rb
Outdated
Show resolved
Hide resolved
…r: undefined method 'file_contents' for nil:NilClass
2264f77
to
712c833
Compare
0bb9d25
to
90f67f3
Compare
test/integration/rake_task_logs_request_with_active_record_test.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of merging this, I might (or you can, if you have time)
- merge this to
master
without the other PR's commits (or revert them) - rebase that other branch off the new
master
- point SC API back at the other pundit WIP branch
The reason is that your PR could cleanly be opened as a PR back to the rake-ui
maintainers. They might merge it and make it part of the main. But the Pundit PR is not yet ready for that.
No description provided.