Skip to content

Commit

Permalink
fix unittest (add wait time)/integration test (remove short option)
Browse files Browse the repository at this point in the history
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
  • Loading branch information
sunya-ch committed Nov 8, 2023
1 parent 4dc3a39 commit 9097282
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/unittest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
uses: docker/setup-buildx-action@v1
- name: Test
run: make build-test
- name: Test pipeline
run: make test-pipeline
- name: Test model server
run: make test-model-server
- name: Test estimator
run: make test-estimator
timeout-minutes: 5
- name: Test pipeline
run: make test-pipeline
- name: Test offline trainer
run: make test-offline-trainer
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ test-estimator: run-estimator run-collector-client clean-estimator
# test estimator --> model-server
run-model-server:
$(CTR_CMD) run -d --platform linux/amd64 -p 8100:8100 --name model-server $(TEST_IMAGE) python3.8 src/server/model_server.py
sleep 10

run-estimator-client:
$(CTR_CMD) exec model-server /bin/bash -c "python3.8 -u ./tests/estimator_model_request_test.py"
Expand Down
2 changes: 1 addition & 1 deletion manifests/set.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ for opt in ${DEPLOY_OPTIONS}; do export $opt=true; done;

echo ${DEPLOY_OPTIONS}

version=$(kubectl version --short | grep 'Client Version' | sed 's/.*v//g' | cut -b -4)
version=$(kubectl version| grep 'Client Version' | sed 's/.*v//g' | cut -b -4)
if [ 1 -eq "$(echo "${version} < 1.21" | bc)" ]
then
echo "You need to update your kubectl version to 1.21+ to support kustomize"
Expand Down

0 comments on commit 9097282

Please sign in to comment.