Merge pull request #296 from sthaha/fix-gha-s3-build-push

chore(gha): fix s3 changed flag
sustainable-computing-io · Jul 9, 2024 · 453028d · 453028d
2 parents c3e316d + 81f40eb
commit 453028d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/push-to-main.yml b/.github/workflows/push-to-main.yml
@@ -37,6 +37,7 @@ jobs:
     outputs:
       base: ${{ steps.filter.outputs.base }}
       modeling: ${{ steps.filter.outputs.modeling }}
+      s3: ${{ steps.filter.outputs.s3 }}
 
     steps:
     - uses: actions/checkout@v4

diff --git a/model_training/tekton/tasks/s3/aws-s3-load.yaml b/model_training/tekton/tasks/s3/aws-s3-load.yaml
@@ -45,8 +45,8 @@ spec:
           secretKeyRef:
             name: $(params.COS_SECRET_NAME)
             key: bucketName
+      command: ["s3-loader"]
       args:
-      - s3-loader
       - aws
       - --aws-access-key-id=$(ACCESS_KEY_ID)
       - --aws-secret-access-key=$(ACCESS_SECRET)

diff --git a/model_training/tekton/tasks/s3/aws-s3-push.yaml b/model_training/tekton/tasks/s3/aws-s3-push.yaml
@@ -42,6 +42,7 @@ spec:
           secretKeyRef:
             name: $(params.COS_SECRET_NAME)
             key: bucketName
+      command: ["s3-pusher"]
       args:
       - s3-pusher
       - aws

diff --git a/model_training/tekton/tasks/s3/ibmcloud-s3-load.yaml b/model_training/tekton/tasks/s3/ibmcloud-s3-load.yaml
@@ -45,8 +45,8 @@ spec:
           secretKeyRef:
             name: $(params.COS_SECRET_NAME)
             key: bucketName
+      command: ["s3-loader"]
       args:
-      - s3-loader
       - ibmcloud
       - --service-endpoint=$(SERVICE_ENDPOINT)
       - --api-key=$(API_KEY)

diff --git a/model_training/tekton/tasks/s3/ibmcloud-s3-push.yaml b/model_training/tekton/tasks/s3/ibmcloud-s3-push.yaml
@@ -42,8 +42,8 @@ spec:
           secretKeyRef:
             name: $(params.COS_SECRET_NAME)
             key: bucketName
+      command: ["s3-pusher"]
       args:
-      - pusher
       - ibmcloud
       - --service-endpoint=$(SERVICE_ENDPOINT)
       - --api-key=$(API_KEY)