Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yaml package for (un)marshaling custom values #66

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Use yaml package for (un)marshaling custom values #66

merged 1 commit into from
Sep 10, 2024

Conversation

atanasdinov
Copy link
Contributor

@atanasdinov atanasdinov commented Sep 2, 2024 •
edited
Loading

  • Moves to YAML unmarshaling from Helm chart values coming from HelmChart resource
  • Keeps JSON unmarshaling from ReleaseManifest resource due to the apiextensionsv1.JSON values

@atanasdinov atanasdinov marked this pull request as draft September 2, 2024 14:27
@atanasdinov atanasdinov marked this pull request as ready for review September 10, 2024 08:01
@atanasdinov atanasdinov merged commit 05331c7 into suse-edge:main Sep 10, 2024
2 checks passed
@atanasdinov atanasdinov deleted the fix-values-unmarshalling branch September 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipetrov117 ipetrov117 ipetrov117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atanasdinov @ipetrov117