Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drain refactor to handle complex cluster types #57

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

ipetrov117
Copy link
Contributor

Refactor drain to handle the following scenarios:

  1. Do not do drains for single and 1 control-plane/ 1 worker clusters
  2. Do control-plane only drain for N control-plane/ 1 worker clusters, where N>1
  3. Do worker only drain for 1 control-plane/ N worker clusters, where N>1
  4. Do drain for both control-plane and worker nodes when cluster is N control-plane/ N worker, where N>1
  5. Offer users the option to disable the drain for control-plane and/or worker nodes from

Test matrix:

  • Do not do drains on single clusters
  • Do not do drains for 1 control-plane/ 1 worker clusters
  • Manually enable drains for small clusters (at user's risk)
  • Do drain for N control-plane/ 1 worker, where N>1
  • Do drain for 1 control-plane/ N workers, where N>1
  • Do drain for N control-plane/ N worker, where N>1
  • Disable drain for control-plane/worker nodes for N control-plane/ N worker clusters

api/v1alpha1/upgradeplan_types.go Outdated Show resolved Hide resolved
internal/controller/upgradeplan_controller.go Outdated Show resolved Hide resolved
internal/controller/upgradeplan_controller.go Show resolved Hide resolved
@ipetrov117 ipetrov117 merged commit 3e14ffd into suse-edge:main Aug 23, 2024
2 checks passed
@ipetrov117 ipetrov117 deleted the drain-refactor branch August 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants