Move arch validation logic outside of OS upgrade script #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested implementation introduces the following changes:
os-upgrade.sh.tpl
script templateSupportedArchs
property of theOperatingSystem
release manifest configuration:[]string
to a[]Arch
typeArch
entry that it holds expected full arch names -x86_64
andaarch64
have been added as initial possible configurations.amd64
,arm64
.. etc.) was added.upgrade-controller
, where:UpgradePlan
andupgrade-controller
respectively.Example "Failed"
UpgradePlan
condition message:Example error message in the
upgrade-controller
for the followingReleaseManifest
configuration:ReleaseManifest:
upgrade-controller
error message when running on ax86_64
OS arch:Was tested both for failure and successful use-cases.