Do OS package upgrades before doing migration #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know what you think of the indentation changes, if you feel like that they do not offer more value I can revert them back to the previous state. |
atanasdinov
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the official SLE Micro upgrade docs the users need to ensure that packages are updated before doing a version migration.
Sadly doing just
transactional-update patchover an older image is not enough for a successful migration.In order to not force users to have to do an additional manual command, this PR introduces an enhancement over the existing OS migration logic, where before migrating we do an automatic update of all OS packages, ensuring that the operation will succeed.
The PR introduces the following code changes:
os-upgrade.shtemplate have been changed in order to make theheredocmore readableos-upgrade.shscript that automatically addsExecStartPre=configurations to the systemd.service when OS migration is done (both OS package upgrade and RPM import are done inExecStartPre=statements).Upgrade screenshots:
Before:
After:
Compressed logs of the OS upgrade pod (different logical sections have been marked for easier reading):