Avoid using VLAN interfaces for physical interface modifications #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
atanasdinov
commented
Mar 18, 2024
•
atanasdinov
commented
- Fixes an issue where the name of a VLAN interface would be used for a physical one due to sharing MAC addresses
- Closes Add support for VLAN based interfaces #46
Signed-off-by: Atanas Dinov <[email protected]>
Signed-off-by: Atanas Dinov <[email protected]>
Signed-off-by: Atanas Dinov <[email protected]>
atanasdinov
changed the title
diconico07
approved these changes
Mar 18, 2024
|
This is so much natural and I have no clue why it didn't come to mind at all.. Fixed! |
Signed-off-by: Atanas Dinov <[email protected]>
atanasdinov
force-pushed
the
nmc-46-vlan-support
branch
from
bf6c814
to
d5985dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.