[#163] Fix code analysis issues

clients/java-client-lib/client-command-api/src/main/java/net/zscript/javaclient/commandbuilder/commandnodes/CommandSequenceNode.java

@@ -132,8 +132,8 @@ public ZscriptCommandNode<?> next() {
                 }
             };
         }
-        return new Iterator<ZscriptCommandNode<?>>() {
-            Iterator<CommandSequenceNode> children = getChildren().iterator();
+        return new Iterator<>() {
+            final Iterator<CommandSequenceNode> children = getChildren().iterator();
             Iterator<ZscriptCommandNode<?>> childIter = null;
 
             @Override

receivers/jvm/java-receiver/src/main/java/net/zscript/javareceiver/notifications/ZscriptNotificationAction.java

@@ -19,7 +19,7 @@ enum NotificationActionType {
     private final ZscriptNotificationSource source;
     private final NotificationActionType    type;
 
-    public ZscriptNotificationAction(ZscriptNotificationSource source, NotificationActionType type) {
+    ZscriptNotificationAction(ZscriptNotificationSource source, NotificationActionType type) {
         this.source = source;
         this.type = type;
     }

receivers/jvm/java-receiver/src/main/java/net/zscript/javareceiver/notifications/ZscriptNotificationSource.java

@@ -139,16 +139,13 @@ public void setNotificationComplete(final boolean b) {
     }
 
     public AsyncActionNotifier getAsyncActionNotifier() {
-        return new AsyncActionNotifier() {
-            @Override
-            public void notifyNeedsAction() {
-                switch (state) {
-                case NOTIFICATION_INCOMPLETE:
-                    state = NotificationSourceState.NOTIFICATION_NEEDS_ACTION;
-                    break;
-                default:
-                    throw new IllegalStateException("Invalid state transition");
-                }
+        return () -> {
+            switch (state) {
+            case NOTIFICATION_INCOMPLETE:
+                state = NotificationSourceState.NOTIFICATION_NEEDS_ACTION;
+                break;
+            default:
+                throw new IllegalStateException("Invalid state transition");
             }
         };
     }

receivers/jvm/java-receiver/src/main/java/net/zscript/javareceiver/semanticParser/ContextView.java

@@ -37,7 +37,7 @@ public interface ContextView {
 
     /**
      * Allows a background/async command component to signal that the command's code needs scheduling to move it along.
-     *
+     * <p/>
      * Example, an interrupt-driven serial writer might call {@link AsyncActionNotifier#notifyNeedsAction()} in its interrupt handler to indicate that the data was all sent
      * correctly. The command will be progressed next time Zscript is given execution time.
      */

receivers/jvm/java-receiver/src/main/java/net/zscript/javareceiver/semanticParser/SemanticAction.java

@@ -133,6 +133,7 @@ private void sendNormalMarkerPrefix(SequenceOutStream out) {
             } else if (marker == Tokenizer.CMD_END_CLOSE_PAREN) {
                 out.writeCloseParen();
             } else if (marker == Tokenizer.NORMAL_SEQUENCE_END) {
+                // no action required
             } else {
                 throw new IllegalStateException("Unknown marker");
             }

receivers/jvm/java-receiver/src/test/java/net/zscript/javareceiver/demoRun/ZscriptPrintingOutStream.java

@@ -1,12 +1,11 @@
 package net.zscript.javareceiver.demoRun;
 
-import java.io.IOException;
 import java.io.PrintStream;
 
 import net.zscript.javareceiver.core.OutputStreamOutStream;
 
 public class ZscriptPrintingOutStream extends OutputStreamOutStream<PrintStream> {
-    public ZscriptPrintingOutStream() throws IOException {
+    public ZscriptPrintingOutStream() {
         super(System.out);
     }
 }

receivers/jvm/java-receiver/src/test/java/net/zscript/javareceiver/fullRun/StringChannel.java

@@ -25,6 +25,7 @@ private StringChannel(TokenBuffer buffer, String input, SequenceOutStream out) {
         this.input = input.getBytes(StandardCharsets.UTF_8);
     }
 
+    @SuppressWarnings("StatementWithEmptyBody")
     @Override
     public void moveAlong() {
         while (index < input.length && in.offer(input[index++])) {

util/misc/src/main/java/net/zscript/util/ByteString.java

@@ -421,7 +421,8 @@ public ByteStringBuilder append(ByteAppendable... appendables) {
          * @param objects zero or more Appendables
          * @return this builder, to facilitate chaining
          */
-        public <T> ByteStringBuilder append(ByteAppender<? super T> appender, T... objects) {
+        @SafeVarargs
+        public final <T> ByteStringBuilder append(ByteAppender<? super T> appender, T... objects) {
             return append(appender, Arrays.asList(objects));
         }
 
@@ -519,7 +520,7 @@ public ByteStringBuilder appendNumeric16KeepZero(int value) {
 
         /**
          * Exposes this Builder as an Appendable to make it easy to append to other ByteStrings.
-         *
+         * <p/>
          * Note: The bytes appended will be those accumulated at the time the ByteAppendable is used, including any added since this method was called. It isn't a frozen snapshot.
          *
          * @return an Appendable adapter that can write this Builder to another Builder

util/misc/src/main/java/net/zscript/util/ExpandableByteBuffer.java

@@ -9,7 +9,7 @@
 
 /**
  * Little utility class that gives expandable byte array capability without the hassle of ByteArrayOutputStream. Used by ByteString to buffer bytes.
- *
+ * <p/>
  * Visible for testing.
  */
 final class ExpandableByteBuffer {