property isVisible doesn't work correctly if layout parameter is emtpy (

#8887)
surveyjs · Oct 2, 2024 · edd6958 · edd6958
1 parent 734562c
commit edd6958
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/survey-core/src/jsonobject.ts b/packages/survey-core/src/jsonobject.ts
@@ -509,7 +509,7 @@ export class JsonObjectProperty implements IObject, IJsonPropertyInfo {
     return this.enableIf(this.getOriginalObj(obj));
   }
   public isVisible(layout: string, obj: any = null): boolean {
-    let isLayout = !this.layout || this.layout == layout;
+    let isLayout = !this.layout || !layout || this.layout === layout;
     if (!this.visible || !isLayout) return false;
     if (!!this.visibleIf && !!obj) {
       return this.visibleIf(this.getOriginalObj(obj));

diff --git a/packages/survey-core/tests/jsonobjecttests.ts b/packages/survey-core/tests/jsonobjecttests.ts
@@ -2145,6 +2145,21 @@ QUnit.test("property.isVisible", function (assert) {
     "Property is invisible in flow layout"
   );
 });
+QUnit.test("title property.isVisible", function (assert) {
+  const prop = Serializer.findProperty("question", "title");
+  prop.visibleIf = (obj: any): boolean => {
+    return obj.name != "abc";
+  };
+  const q = new QuestionTextModel("q1");
+  assert.equal(prop.isVisible("row", q), true, "row, #1");
+  assert.equal(prop.isVisible("detail", q), false, "detail #2");
+  assert.equal(prop.isVisible("", q), true, "empty #1");
+  q.name = "abc";
+  assert.equal(prop.isVisible("row", q), false, "row, #2");
+  assert.equal(prop.isVisible("detail", q), false, "detail #2");
+  assert.equal(prop.isVisible("", q), false, "empty #2");
+  (<any>prop).visibleIf = undefined;
+});
 
 QUnit.test("property.baseValue", function (assert) {
   Serializer.addProperty("questionbase", {