nouislider: fixed rendering in higher angular version #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joostluijben
changed the title
tsv2013
requested changes
Nov 10, 2022
| @@ -123,8 +123,6 @@ function init(Survey) { | |||
| }); | |||
| question.updateSliderProperties = function () { | |||
| const elems = document.getElementsByClassName("noUi-pips"); | |||
| if (elems.length > 0) elems[elems.length - 1].style.display = "none"; | |||
There was a problem hiding this comment.
Why do we need to remove this (and below) line?
| @@ -226,10 +224,4 @@ function init(Survey) { | |||
| }, | |||
| }; | |||
| Survey.CustomWidgetCollection.Instance.addCustomWidget(widget, "customtype"); | |||
| } | |||
|
|
|||
| if (typeof Survey !== "undefined") { | |||
There was a problem hiding this comment.
If we remove this call, custom widget will not be registered in non-modular applications
| init(Survey); | ||
| } | ||
|
|
||
| export default init; |
There was a problem hiding this comment.
Does the "default" export cause problems with higher Angular versions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nouislider component was not rendering for me. After adding the source code found from here as a custom component and changing these lines it was rendering for me.
Using
angular version 18.3.9
node version: 16.8.1
typescript: 4.4.2
npm: 8.19.2