Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KV store #5

Merged
merged 87 commits into from
Jan 11, 2024
Merged

Add KV store #5

merged 87 commits into from
Jan 11, 2024

Conversation

arriqaaq
Copy link
Contributor

@arriqaaq arriqaaq commented Nov 20, 2023

This is a draft PR for the KV store with a bunch of pending changes as listed below:

Store Changes

  • Fix Range scans (scans don't stop at end bound)
  • Remove dependency from VariableKey during scan reads
  • Add hermitage tests for SSI
  • Add Per KV checksum
  • Fix options which are not implemented
  • Add hermitage tests for SI
  • Make BLOCK_SIZE = 32kb
  • Add key reader (scan support) to track reading multiple keys in a transaction
  • Add Read Cache
  • Store all database options in file header
  • Add close method to store
  • Fix value reference decode
  • Need to terminate keys when inserting to snapshot and index (Foo vs foo2 bug (bytes need to be appended with delimiter “\0” as in vector key for art to differentiate))
  • Improve Store API (create vector/array key from byte array instead of making the user import Vector/Array key, and remove dependency on bytes::Bytes for txn api)

src/storage/index/art.rs Outdated Show resolved Hide resolved
src/storage/index/iter.rs Outdated Show resolved Hide resolved
src/storage/index/iter.rs Outdated Show resolved Hide resolved
src/storage/index/mod.rs Outdated Show resolved Hide resolved
src/storage/index/mod.rs Outdated Show resolved Hide resolved
src/storage/index/mod.rs Outdated Show resolved Hide resolved
src/storage/log/aof/log.rs Show resolved Hide resolved
src/storage/log/mod.rs Outdated Show resolved Hide resolved
src/storage/log/mod.rs Outdated Show resolved Hide resolved
src/storage/log/mod.rs Show resolved Hide resolved
src/storage/log/wal/log.rs Outdated Show resolved Hide resolved
@arriqaaq arriqaaq force-pushed the add-store branch 2 times, most recently from 51ea1c5 to 19721de Compare December 21, 2023 12:32
@arriqaaq arriqaaq marked this pull request as ready for review January 11, 2024 09:25
@arriqaaq arriqaaq merged commit 0f14ae2 into main Jan 11, 2024
@arriqaaq arriqaaq deleted the add-store branch January 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants