move mapToStruct to marshal package #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added unit tests
phughk
approved these changes
Dec 8, 2023
| @@ -162,3 +163,77 @@ func SmartMarshal[I any](inputfunc interface{}, data I) (output interface{}, err | |||
| } | |||
| return nil, ErrNotValidFunc | |||
| } | |||
|
|
|||
| // UnmarshalMapToStruct unmarshals a map[string]interface{} to a struct. | |||
| func UnmarshalMapToStruct(data map[string]interface{}, outStruct interface{}) error { | |||
There was a problem hiding this comment.
I'm ok with this moving, but we need to remember that this will change with the introduction of Column and Rows
There was a problem hiding this comment.
Yes, of course, but for now, we should continue to improve the project in meanwhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added unit tests
fix #106