Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the with-labstack-echo example #411

Merged

Conversation

furkansenharputlu
Copy link
Contributor

@furkansenharputlu furkansenharputlu commented May 1, 2024

Summary of change

The issue is related to the usage of echo middleware in the with-labstack-echo example. Returning the hf(c) call will fix it.

Why does it fix the issue?
Because the error returned from the handler function is ignored when you don't return its result in the middleware chain. In the example, it ignores what hf(c) returns, instead returns nil. When we return as return hf(c), the result of hf(c) will be respected.

Related issues

https://discord.com/channels/603466164219281420/1227846962477535232

Test Plan

Added a test.

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

@furkansenharputlu furkansenharputlu changed the base branch from master to 0.17 May 1, 2024 11:13
@furkansenharputlu furkansenharputlu force-pushed the fix/labstack-example branch 4 times, most recently from b0da2d6 to ebf7cfa Compare May 1, 2024 11:45
@rishabhpoddar rishabhpoddar changed the base branch from 0.17 to 0.18 May 1, 2024 11:50
CHANGELOG.md Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit 0ca19ca into supertokens:0.18 May 1, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants