Feat/cli next/solid #132
Open
Feat/cli next/solid #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcellus
requested changes
Dec 24, 2024
Comment on lines
+6
to
+11
| const [sessionExists, setSessionExists] = useState(false); | ||
| useEffect(() => { | ||
| Session.doesSessionExist().then((exists) => { | ||
| setSessionExists(exists); | ||
| }); | ||
| }, []); |
There was a problem hiding this comment.
I'd prefer if we used the useSessionContext where it's available (in react), we do not want to give the impression that you need to do this (plus it's act
| @@ -14,7 +14,7 @@ const loadScript = (src: string) => { | |||
|
|
|||
| export const Auth = () => { | |||
| onMount(() => { | |||
| loadScript("${jsdeliveryprebuiltuiurl}"); | |||
| const handleCall = handleAuthAPIRequest(); | ||
|
|
||
| export const ALL: APIRoute = async ({ request }) => { | ||
| console.log("api auth"); |
There was a problem hiding this comment.
I think we can remove this.
| @@ -5,6 +5,7 @@ import type { APIRoute } from "astro"; | |||
| const handleCall = handleAuthAPIRequest(); | |||
|
|
|||
| export const ALL: APIRoute = async ({ request }) => { | |||
| console.log("api auth"); | |||
There was a problem hiding this comment.
There are lots of this added. We can keep them but they seem unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change