Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning #4359

Open
wants to merge 13 commits into
base: nightly_dev
Choose a base branch
from
Open

Conversation

wschadow
Copy link

@wschadow wschadow commented Jul 8, 2024

These commits eliminate a lot of warnings while compiling (unused variables and functions, indenation, improper types). Inaddition there is one commit that does some cosmetics: remove trailing blanks and replaces tabs with 4 spaces.

@supermerill
Copy link
Owner

I'm okay with removing warnings.
But Please don't touch at the tabs & trailing spaces put by prusa, as these changes will make merging a pain.
You can remove the ones that are on my modified lines, if you find any.

Copy link
Owner

@supermerill supermerill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many changes that will makes merging harder. Please ask that in prusaslicer first.

@wschadow
Copy link
Author

wschadow commented Jul 9, 2024

ok, I understand the issue when merging from Prusa. I'll prepare a cleaner pull request for the elimination of warnings.

@Ocraftyone
Copy link

I work on the OrcaSlicer project and I would LOVE to do this to Orca as well. Biggest issue is merging between the projects. Maybe we can get all of the Slic3r projects to agree on a clang-format standard and we could format all of the projects? In a perfect world :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants