Fix disabling supermaven-nvim conditionally #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context I'm using the conditional mechanism to keep supermaven disabled by default and only enabled for specific filetypes (there is no other way to achieve this currently).
The way the
conditionfeature is described in the README leads me to suggest that to accomplish this "default off" behaviour I should be able to use this mechanism.The original code will basically shut down supermaven completely whenever the
conditionfunction is evaluated to false, this becomes a problem if you have multiple files open in the same neovim session, as soon as you open one which has a falseconditionthen immediately supermaven is shut down for all other files.This PR fixes this issue by using the
conditionin much the same way that theignore_filetypesis used.