[SuperTextField][Android] Fix drag handle jumping when adding text at the end (Resolves #1114) #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool get _shouldShowCollapsedHandle => | ||
| widget.editingController.textController.selection.isCollapsed && !_isDraggingBase && !_isDraggingExtent; | ||
|
|
||
| /// Holds the offset in text layout space where the collapsed drag handle is displayed. |
There was a problem hiding this comment.
Did you test to see if any similar positioning issues occur with expanded handles?
There was a problem hiding this comment.
I didn't notice issues like this with expanded handles.
| /// Update the offset for the collapsed handle and call `setState`. | ||
| /// | ||
| /// Re-schedules the update if we can't compute compute the offset at the current frame. | ||
| void _updateOffsetForCollapsedHandleAndRebuild() { |
There was a problem hiding this comment.
This looks nearly identical to the other method.
There was a problem hiding this comment.
Yeah, this is nearly identical. The only difference is that one method directly assignes the value because it is called in the build phase and the other calls setState.
There was a problem hiding this comment.
So we should de-duplicate it.
There was a problem hiding this comment.
After reviewing and testing again, it seems we don't need two methods. We aren't calling this from the build phase.
Updated.
angelosilvestre
force-pushed
the
1114_drag_handle_jumping
branch
from
a9efa9e
to
b338d05
Compare
angelosilvestre
added a commit
to angelosilvestre/super_editor
that referenced
this pull request
Jul 25, 2023
quaaantumdev
pushed a commit
to quaaantumdev/super_editor
that referenced
this pull request
Aug 2, 2023
raulmabe-labhouse
pushed a commit
to LabhouseMobile/super_editor
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperTextField][Android] Fix drag handle jumping when adding text at the end. Resolves #1114
When the text field is center-aligned, typing at the end of the text field causes the drag handle to "flash" at the center of the text field before being displayed at the correct position:
2023-05-09.19-56-12.mp4
The cause seems to be a timing issue. We are computing the drag handle offset during build and it seems we are requesting the caret offset while the text layout isn't updated with the new text.
This PR changes the
AndroidEditingOverlayControlsto compute and cache the caret offset in a post-frame callback after the text/selection changes.After the changes:
2023-05-09.20-00-09.mp4
Unfortunately, I couldn't write a test for it. We don't seem to have the same timing issues in the widget tests.