Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shopify demo use cases #384

Draft
wants to merge 7 commits into
base: main_wasm
Choose a base branch
from
Draft

Conversation

Jakub-Vacek
Copy link
Member

@Jakub-Vacek Jakub-Vacek commented May 5, 2023

Description

This PR adds basic use cases for Shopify. All of them works (tested with providers cred).

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Jakub-Vacek Jakub-Vacek changed the title [WIP]feat: shopify demo use cases feat: shopify demo use cases May 9, 2023
Copy link
Member

@zdne zdne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jakub-Vacek seems like the results miss description fields why inputs have them?

@zdne
Copy link
Member

zdne commented May 9, 2023

@Jakub-Vacek also the "error" handling seems a bit naive. For instance, rate limits are problems with Shopify API and could be good to handle them well.

@Jakub-Vacek
Copy link
Member Author

@Jakub-Vacek seems like the results miss description fields why inputs have them?

I prompted AI to do it this way - input is provided by user sou some guidance can be useful. We can remove them from input or add them to result as wall.

@Jakub-Vacek also the "error" handling seems a bit naive. For instance, rate limits are problems with Shopify API and could be good to handle them well.

It is naive, AI lacks info about rate limiting (I am trying to add it now) so there is room for improvement.

@zdne
Copy link
Member

zdne commented May 9, 2023

@Jakub-Vacek seems like the results miss description fields why inputs have them?

I prompted AI to do it this way - input is provided by user sou some guidance can be useful. We can remove them from input or add them to result as wall.

I like it and, if feasible, I would add it to the result too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants