Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TypeScript profiles #120

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

TheEdward162
Copy link
Contributor

  • both Comlink and TypeScript profiles are supported
  • by default OneSDK looks for .profile.ts files but if not found it falls back to .profile files
  • core only parses the file name so the changes are minimal
  • move loose utility classes/files in javascript_common/lib for better organisation

* both Comlink and TypeScript profiles are supported
* by default OneSDK looks for .profile.ts files but if not found it falls back to .profile files
* core only parses the file name so the changes are minimal
* move loose utility classes/files in javascript_common/lib for better organisation
Copy link
Member

@freaz freaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 simple changes, and looks good.

@TheEdward162 TheEdward162 merged commit 4356a07 into main Nov 23, 2023
5 checks passed
@TheEdward162 TheEdward162 deleted the feat/typescript_profiles branch November 23, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants