Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: map_std as a package, release workflow #118

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat: map_std as a package, release workflow #118

merged 2 commits into from
Nov 22, 2023

Conversation

TheEdward162
Copy link
Contributor

  • crate map_std package which exports core_js/map-std types for tool authoring
  • extract package prepare into local action to reduce complexity of release workflow
  • export Safety, Usecase and UsecaseExamples from map-std as global types

@TheEdward162
feat: map_std as a package, release workflow
cf90420 
* crate map_std package which exports core_js/map-std types for tool authoring
* extract package prepare into local action to reduce complexity of release workflow
* export Safety, Usecase and UsecaseExamples from map-std as global types
freaz
freaz approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@freaz freaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing release pipeline. 💪

One thing I am thinking about, is documenting what is actually AnyValue. Because it looks strange on first look.

Makefile Show resolved Hide resolved
@TheEdward162
chore: update documentation of AnyValue type
631720f 
* also fix missing .npmignore in map_std
@TheEdward162
Copy link
Contributor Author

I've added some documentation to AnyValue and other global types

@TheEdward162 TheEdward162 merged commit 14a3426 into main Nov 22, 2023
5 checks passed
@TheEdward162 TheEdward162 deleted the feat/release_mapstd_package branch November 22, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freaz freaz freaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheEdward162 @freaz