This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
feat: one sdk log env #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julpat
reviewed
Aug 18, 2023
| }): NewDotenv { | ||
| const previousContent = previousDotenv ?? ''; | ||
|
|
||
| const parameterEnvs = getParameterEnvs(providerName, parameters); | ||
| const securityEnvs = getSecurityEnvs(providerName, security); | ||
| const tokenEnv = makeTokenEnv(token); | ||
| const logEnv = makeLogEnv(logEnabled === true ? '"on"' : '"off"'); |
There was a problem hiding this comment.
The motivation to change the default value is that user could have it already set up (e.g. using export in the terminal)?
There was a problem hiding this comment.
I also don't see the point for this condition right now if the goal was to promote the env :)
There was a problem hiding this comment.
This is just in case we might change the value. If you think that it is not needed I will remove it :)
| }: { | ||
| previousDotenv?: string; | ||
| providerName: string; | ||
| parameters?: IntegrationParameter[]; | ||
| security?: SecurityScheme[]; | ||
| token?: string | null; | ||
| logEnabled?: boolean; |
There was a problem hiding this comment.
You are not passing this new argument. So it's only for potential use in the future?
kysely
reviewed
Aug 18, 2023
| }): NewDotenv { | ||
| const previousContent = previousDotenv ?? ''; | ||
|
|
||
| const parameterEnvs = getParameterEnvs(providerName, parameters); | ||
| const securityEnvs = getSecurityEnvs(providerName, security); | ||
| const tokenEnv = makeTokenEnv(token); | ||
| const logEnv = makeLogEnv(logEnabled === true ? '"on"' : '"off"'); |
There was a problem hiding this comment.
I also don't see the point for this condition right now if the goal was to promote the env :)
Co-authored-by: Radek Kyselý <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ONESDK_LOG= env variable to generated .env file with default value "off"
#355
Motivation and Context
Types of changes
Checklist: